Skip to content

Conversation

@filipcirtog
Copy link
Collaborator

Summary

The ConnectionSecret package was originally designed to serve multiple components, including Atlas Data Federation, Atlas Database users, and Atlas Deployments. To better align with its purpose, I have renamed ConnectionSecret to SecretService, as this name more accurately reflects its role. This change also frees up the ConnectionSecret package name, which can now be reused for experimental code in the future. I have also moved some logic only used by AtlasDatabaseUsers in that package.

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great solution

@filipcirtog filipcirtog changed the title ConnectionSecret refactoring Legacy ConnectionSecret refactoring Sep 18, 2025
@filipcirtog filipcirtog marked this pull request as ready for review September 18, 2025 09:36
@filipcirtog filipcirtog requested a review from a team as a code owner September 18, 2025 09:36
@filipcirtog filipcirtog merged commit 98a62d8 into main Sep 19, 2025
220 of 221 checks passed
@filipcirtog filipcirtog deleted the connectionsecret-refactoring branch September 19, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants