Conversation
879a0a3 to
aaf57d7
Compare
go.mod
Outdated
| sigs.k8s.io/yaml v1.6.0 | ||
| ) | ||
|
|
||
| tool fybrik.io/crdoc |
There was a problem hiding this comment.
this is very cool but this should not be main go.mod
There was a problem hiding this comment.
let's put this as a separate go.mod in tools/crdoc
There was a problem hiding this comment.
FYI: I know we decided this, but I am making some experiments and go-licenses does seem to correctly ignore tools with troublesome licenses, as they are not part of the project product. Here is an example in the experiment PR #2716 has golangci-lint (GPLv3) managed within the main go.mod.
My suggestion here, don't change this back leave it in tools/toolbox and will take care of this change as part of the mentioned PR if we decided using main is safe and has a better DX (Developer eXperience).
s-urbaniak
left a comment
There was a problem hiding this comment.
we cannot merge until the TD is LGTM'ed
|
Code LGTM as of now, but also waiting on the TD |
|
LGTM, but needs rebase. I will approve once conflicts are solved |
4ccb08e to
d1b3bdf
Compare
Summary
Use CRDoc to generate CRD API docs.
This is using
go toolto install crdoc.GitHub Actions also checks that the API docs are updated when creating a PR, similar to the existing checks for CRDs themselves.
Proof of Work
Checklist
Reminder (Please remove this when merging)