Skip to content

CLOUDP-336726: Autogenerate API Docs#2711

Merged
roothorp merged 5 commits intomainfrom
cloudp-336726-gen-docs
Oct 2, 2025
Merged

CLOUDP-336726: Autogenerate API Docs#2711
roothorp merged 5 commits intomainfrom
cloudp-336726-gen-docs

Conversation

@roothorp
Copy link
Collaborator

Summary

Use CRDoc to generate CRD API docs.
This is using go tool to install crdoc.
GitHub Actions also checks that the API docs are updated when creating a PR, similar to the existing checks for CRDs themselves.

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@roothorp roothorp requested a review from a team as a code owner September 22, 2025 08:50
@roothorp roothorp force-pushed the cloudp-336726-gen-docs branch from 879a0a3 to aaf57d7 Compare September 22, 2025 08:53
go.mod Outdated
sigs.k8s.io/yaml v1.6.0
)

tool fybrik.io/crdoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very cool but this should not be main go.mod

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's put this as a separate go.mod in tools/crdoc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I know we decided this, but I am making some experiments and go-licenses does seem to correctly ignore tools with troublesome licenses, as they are not part of the project product. Here is an example in the experiment PR #2716 has golangci-lint (GPLv3) managed within the main go.mod.

My suggestion here, don't change this back leave it in tools/toolbox and will take care of this change as part of the mentioned PR if we decided using main is safe and has a better DX (Developer eXperience).

Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot merge until the TD is LGTM'ed

@josvazg
Copy link
Collaborator

josvazg commented Sep 23, 2025

Code LGTM as of now, but also waiting on the TD

@josvazg
Copy link
Collaborator

josvazg commented Sep 30, 2025

LGTM, but needs rebase. I will approve once conflicts are solved

@roothorp roothorp force-pushed the cloudp-336726-gen-docs branch from 4ccb08e to d1b3bdf Compare October 2, 2025 09:42
@roothorp roothorp requested a review from a team October 2, 2025 10:10
@roothorp roothorp merged commit 37d2456 into main Oct 2, 2025
22 checks passed
@roothorp roothorp deleted the cloudp-336726-gen-docs branch October 2, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants