Skip to content

Conversation

@filipcirtog
Copy link
Collaborator

@filipcirtog filipcirtog commented Sep 30, 2025

Summary

This Pull Request introduces the ConnectionSecret controller as an experimental feature within AKO. The addition will enable us to test the design and functionality on the side before exposing the work to end users. Unit tests are included for the experimental implementation.

Proof of Work

  • The controller now watched the AtlasDatabaseUser instead the Secret, allowing us to discard the internal request naming processing (i.e. with $).
  • Improved Naming Conventions: Renamed various components for better clarity and understanding.
  • Adoption of SSA vs. GET+UPDATE: Introduced Server-Side Apply (SSA) to resource update compared to the previous GET+UPDATE approach.
  • ConnectionSecret Updates: Renamed connections secrets, updated labels, and added a new annotation to specify the origin of each connection secret.
  • Experimental Mode Introduction: Introduced the feature as experimental, building new resources alongside the existing ones.
  • Reversion of Deletions & Legacy Code Isolation: Restored previously deleted components and ensured separation from legacy code.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

andrpac and others added 30 commits August 21, 2025 18:34
chore: create tests, cleanup old code, refactor controller
chore: cleanups after review
@filipcirtog filipcirtog merged commit ed9a9a3 into main Oct 10, 2025
112 checks passed
@filipcirtog filipcirtog deleted the CLOUUDP-334941/refactored-experimental-secret-controller branch October 10, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants