Skip to content

Conversation

@s-urbaniak
Copy link
Collaborator

Summary

This moves a direct go test ... call from github actions into make so we can consolidate logic.

Proof of Work

green CI

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@s-urbaniak s-urbaniak requested a review from a team as a code owner October 8, 2025 15:55
.PHONY: unit-test
unit-test:
go test -race -cover $(GO_UNIT_TEST_FOLDERS)
unit-test: manifests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed for transient directories in #2764

@s-urbaniak s-urbaniak changed the title use make target for unit testing including dependencies CLOUDP-349340 : use make target for unit testing including dependencies Oct 8, 2025
@s-urbaniak s-urbaniak changed the title CLOUDP-349340 : use make target for unit testing including dependencies CLOUDP-349340: use make target for unit testing including dependencies Oct 8, 2025
@s-urbaniak s-urbaniak merged commit 5b5f54b into main Oct 8, 2025
22 checks passed
@s-urbaniak s-urbaniak deleted the unit-tests-target branch October 8, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants