-
Notifications
You must be signed in to change notification settings - Fork 108
CLOUDP-362265: Simplify Existing CI #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4a503c3 to
55fad0b
Compare
55fad0b to
2dad20f
Compare
.github/workflows/build-images.yaml
Outdated
| uses: ./.github/actions/build-push-image | ||
| with: | ||
| file: fast.Dockerfile | ||
| version: ${{ needs.prepare-e2e.outputs.next_version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| version: ${{ needs.prepare-e2e.outputs.next_version }} | |
| version: ${{ needs.get-version.outputs.version }} |
.github/workflows/build-images.yaml
Outdated
| - name: Check out code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.sha}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ref: ${{github.event.pull_request.head.sha}} | |
| ref: ${{ github.event.pull_request.head.sha || github.sha }} |
.github/workflows/build-images.yaml
Outdated
| OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ steps.get-version.outputs.image_tag }} | ||
| VERSION: ${{ steps.get-version.outputs.image_tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ steps.get-version.outputs.image_tag }} | |
| VERSION: ${{ steps.get-version.outputs.image_tag }} | |
| OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ needs.get-version.outputs.image_tag }} | |
| VERSION: ${{ needs.get-version.outputs.image_tag }} |
.github/workflows/build-images.yaml
Outdated
| - name: Checkout Code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branchName || github.event.pull_request.head.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branchName || github.event.pull_request.head.sha }} | |
| ref: ${{ github.event.pull_request.head.sha || github.sha }} |
e89b606 to
09cea37
Compare
Summary
Proof of Work
Checklist
Reminder (Please remove this when merging)