Skip to content

Conversation

@roothorp
Copy link
Collaborator

Summary

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@roothorp roothorp marked this pull request as ready for review January 19, 2026 11:26
@roothorp roothorp requested a review from a team as a code owner January 19, 2026 11:26
@roothorp roothorp added cloud-tests Run expensive Cloud Tests: Integration & E2E and removed test/e2e/teams labels Jan 19, 2026
@roothorp roothorp marked this pull request as draft January 19, 2026 11:30
@roothorp roothorp force-pushed the cloudp-362265-simplify-ci branch 9 times, most recently from 4a503c3 to 55fad0b Compare January 22, 2026 13:25
@roothorp roothorp force-pushed the cloudp-362265-simplify-ci branch from 55fad0b to 2dad20f Compare January 26, 2026 15:13
@roothorp roothorp marked this pull request as ready for review January 27, 2026 10:39
uses: ./.github/actions/build-push-image
with:
file: fast.Dockerfile
version: ${{ needs.prepare-e2e.outputs.next_version }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: ${{ needs.prepare-e2e.outputs.next_version }}
version: ${{ needs.get-version.outputs.version }}

- name: Check out code
uses: actions/checkout@v6
with:
ref: ${{github.event.pull_request.head.sha}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ref: ${{github.event.pull_request.head.sha}}
ref: ${{ github.event.pull_request.head.sha || github.sha }}

Comment on lines 87 to 88
OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ steps.get-version.outputs.image_tag }}
VERSION: ${{ steps.get-version.outputs.image_tag }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ steps.get-version.outputs.image_tag }}
VERSION: ${{ steps.get-version.outputs.image_tag }}
OPERATOR_IMAGE: ${{ env.GHCR_REPO }}:${{ needs.get-version.outputs.image_tag }}
VERSION: ${{ needs.get-version.outputs.image_tag }}

- name: Checkout Code
uses: actions/checkout@v6
with:
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branchName || github.event.pull_request.head.sha }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branchName || github.event.pull_request.head.sha }}
ref: ${{ github.event.pull_request.head.sha || github.sha }}

@roothorp roothorp force-pushed the cloudp-362265-simplify-ci branch from e89b606 to 09cea37 Compare January 29, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud-tests Run expensive Cloud Tests: Integration & E2E test/e2e/users test/int/* test/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants