Conversation
fc6ba4f to
f139fa7
Compare
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
f139fa7 to
b3a63ba
Compare
| @@ -0,0 +1,4 @@ | |||
| [ | |||
| "Group" | |||
There was a problem hiding this comment.
why is this special treatment needed?
There was a problem hiding this comment.
The idea is that we produce generated resources once, as done today, but them pick which ones are promoted as production ready.
I am open to alternatives, but one thing I would like to keep is that we should be able to work on experimental resources without releasing them until ready. Smaller PRs, and protecting production from ongoing work are important.
There was a problem hiding this comment.
An alternative is we use a separate source for generated production CRDs, which would implying moving from experimental to production means cut the CRD schema from the experimental file and pasting into the production one. Not sure we want to go that path.
Another option is the other way around, mark experimental ones instead of production ready. But that is kind of dangerous, as we might expose experimental code by accident.
There was a problem hiding this comment.
I am not convinced we need experimental support any more and introduce more complexity. we know we want to promote these CRDs now, why do we want to add additional complexity, I don't see a requirement from the PD+Scope/TD for this.
|
We are going for solving the experimental/non experimental split in the openapi2crd config, by using different domains in the group version. Experimental will be optional, not a pre-step before promoting as prod. |
Summary
Make Group non experimental
config/generated/crd/production-kinds.jsonis an array promoting generated CRDs to production.legacyReconcilersandgeneratedReconcilersfunctions.legacyIndexersandgeneratedIndexers.crds.experimental.yamland individual YAML files underconfig/crd/bases.This this setup, we can continue to write experimental generated resources and chose when to promote them to production at will.
Proof of Work
TBD
Checklist