-
Notifications
You must be signed in to change notification settings - Fork 523
Improvements for local development setup process #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for local development setup process #1589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice setup improvements ! 👏
Left a few comments but LGTM overall
(please wait for others to have a look before merging)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be great to get an answer from @mircea-cosbuc regarding the kind setup changes. But I won't block on these.
Summary:
This PR will improve the setup process for local development of the mongodb-kubernetes-operator. The documentation contained outdated and misleading information. Also some problems with building images and deploying the operator were encountered because of using a local registry. This
The PR adds:
Makefile
:config.json
file toagent_image
--ignore-not-found
flag touninstall-crd
target because of errors encountered when calling this during themake deploy
command where no crd was installed yet$(IMG_BUILD_ARGS)
to all image building targets to allow the--insecure
flag to be passed as a paramterinventory.yaml
file:agent_distro
andtools_distro
agent_distro
andtools_distro
in buildargs to be extracted from the paramspipeline.py
file:insecure
to be passedsetup_kind_cluster.sh
:All Submissions: