Skip to content

Conversation

mateigrigore
Copy link
Contributor

Summary:

This PR will improve the setup process for local development of the mongodb-kubernetes-operator. The documentation contained outdated and misleading information. Also some problems with building images and deploying the operator were encountered because of using a local registry. This

The PR adds:

  • Documentation changes to improve the local setup process
  • Changes to the Makefile:
    • Change the name of the parameter to look for the agent image in the config.json file to agent_image
    • Add --ignore-not-found flag to uninstall-crd target because of errors encountered when calling this during the make deploy command where no crd was installed yet
    • Add $(IMG_BUILD_ARGS) to all image building targets to allow the --insecure flag to be passed as a paramter
  • Changes to the inventory.yaml file:
    • Removed default values for agent_distro and tools_distro
    • Changed the values for agent_distro and tools_distro in buildargs to be extracted from the params
  • Changes to the pipeline.py file:
    • Allow for a new argument insecure to be passed
  • Chnages to the setup_kind_cluster.sh:
    • Add the registry config to the nodes

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@mateigrigore mateigrigore changed the title Improvements for local setup process Improvements for local development setup process Jul 18, 2024
Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice setup improvements ! 👏
Left a few comments but LGTM overall
(please wait for others to have a look before merging)

@nammn nammn added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Jul 22, 2024
Copy link
Collaborator

@nammn nammn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be great to get an answer from @mircea-cosbuc regarding the kind setup changes. But I won't block on these.

@mircea-cosbuc mircea-cosbuc merged commit 1947a00 into mongodb:master Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants