Skip to content

Conversation

mateigrigore
Copy link
Contributor

@mateigrigore mateigrigore commented Aug 7, 2024

Summary:

helm changes: mongodb/helm-charts#340

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for your first release !
Left a few comments regarding spelling and syntax on the release notes

Otherwise LGTM, well done


All container images published for the community operator are signed with our private key. This is visible on our Quay registry. Signature can be verified using our public key, which is available at [this address](https://cosign.mongodb.com/mongodb-enterprise-kubernetes-operator.pem).
## Documentation improvements
Improvements were made to the documentatio of using the community operator as well as the one for local development.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here

## ReadinessProbe error logging
- fixed a red herring which caused the probe to panic when the health status is not available. Instead it will just log the error
## Bug Fixes
- Users removed from the resource are now also deleted from the database and their connection string secretes are cleaned up
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here as well (secretes)

- fixed a red herring which caused the probe to panic when the health status is not available. Instead it will just log the error
## Bug Fixes
- Users removed from the resource are now also deleted from the database and their connection string secretes are cleaned up
- Colisions of the scram secret name will now be spotted by spec validation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo as well here (spelling)
I would rephrase it with something like "Scram secret name collisions will now be caught when validating specs."

Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mateigrigore mateigrigore merged commit c5170eb into master Aug 8, 2024
47 checks passed
@mateigrigore mateigrigore deleted the release-0.11.0 branch August 8, 2024 12:46
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Review and publish the release here: https://github.com/mongodb/mongodb-kubernetes-operator/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants