Skip to content
This repository was archived by the owner on Dec 12, 2025. It is now read-only.

CLOUDP-302068: Remove annotations arg from GetMongoDBVersion#1677

Merged
m1kola merged 1 commit intomongodb:masterfrom
m1kola:remove_annotations_arg_from_GetMongoDBVersion
Mar 11, 2025
Merged

CLOUDP-302068: Remove annotations arg from GetMongoDBVersion#1677
m1kola merged 1 commit intomongodb:masterfrom
m1kola:remove_annotations_arg_from_GetMongoDBVersion

Conversation

@m1kola
Copy link
Collaborator

@m1kola m1kola commented Feb 21, 2025

Summary:

This is no longer needed.

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@m1kola m1kola added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Feb 21, 2025
@m1kola m1kola force-pushed the remove_annotations_arg_from_GetMongoDBVersion branch from c1e426e to e2c224d Compare February 21, 2025 14:26
@m1kola m1kola added safe-to-test Add this label to PRs from forks to trigger E2E tests and removed safe-to-test Add this label to PRs from forks to trigger E2E tests labels Feb 21, 2025
@m1kola m1kola force-pushed the remove_annotations_arg_from_GetMongoDBVersion branch from e2c224d to 54b5d7b Compare March 7, 2025 16:21
@m1kola m1kola added safe-to-test Add this label to PRs from forks to trigger E2E tests and removed safe-to-test Add this label to PRs from forks to trigger E2E tests labels Mar 7, 2025
@m1kola m1kola force-pushed the remove_annotations_arg_from_GetMongoDBVersion branch from 54b5d7b to f535442 Compare March 10, 2025 16:46
@m1kola m1kola force-pushed the remove_annotations_arg_from_GetMongoDBVersion branch from f535442 to 380cfa1 Compare March 10, 2025 16:48
@m1kola m1kola added safe-to-test Add this label to PRs from forks to trigger E2E tests and removed safe-to-test Add this label to PRs from forks to trigger E2E tests labels Mar 10, 2025
@m1kola m1kola marked this pull request as ready for review March 10, 2025 16:58
mircea-cosbuc
mircea-cosbuc approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m1kola m1kola merged commit 0e72089 into mongodb:master Mar 11, 2025
50 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@nammn nammn Awaiting requested review from nammn nammn is a code owner

@MaciejKaras MaciejKaras Awaiting requested review from MaciejKaras MaciejKaras is a code owner

@lucian-tosa lucian-tosa Awaiting requested review from lucian-tosa lucian-tosa is a code owner

@fealebenpae fealebenpae Awaiting requested review from fealebenpae fealebenpae is a code owner

2 more reviewers

@mircea-cosbuc mircea-cosbuc mircea-cosbuc approved these changes

@Julien-Ben Julien-Ben Julien-Ben approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

safe-to-test Add this label to PRs from forks to trigger E2E tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m1kola @mircea-cosbuc @Julien-Ben