CLOUDP-331841 - remove the agent matrix work #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
force-pushed
the
remove-agent-matrix
branch
from
d76eda3 to
08c2c49
Compare
nammn
changed the title
nammn
requested review from
fealebenpae,
lucian-tosa,
MaciejKaras and
Julien-Ben
MaciejKaras
reviewed
Aug 6, 2025
changelog/20250806_breaking_changing_container_setup_of_static_architecture.md
Outdated
Show resolved
Hide resolved
MaciejKaras
reviewed
Aug 6, 2025
changelog/20250806_breaking_changing_container_setup_of_static_architecture.md
Outdated
Show resolved
Hide resolved
MaciejKaras
reviewed
Aug 6, 2025
nammn
commented
Aug 6, 2025
Julien-Ben
reviewed
Aug 6, 2025
nammn
requested review from
MaciejKaras,
Julien-Ben,
mircea-cosbuc,
anandsyncs and
viveksinghggits
MaciejKaras
approved these changes
Aug 8, 2025
MaciejKaras
approved these changes
Aug 8, 2025
lucian-tosa
reviewed
Aug 8, 2025
Comment on lines
+177
to
+183
| } else { | ||
| staticMounts := []corev1.VolumeMount{hooksVolumeMount, scriptsVolumeMount, tmpVolumeMount} | ||
| withStaticContainerModification = podtemplatespec.WithContainer(util.AgentContainerUtilitiesName, mongodbAgentUtilitiesContainer(staticMounts, initAppDBImage)) | ||
| mongodbAgentVolumeMounts = append(mongodbAgentVolumeMounts, staticMounts...) | ||
| shareProcessNs = func(sts *appsv1.StatefulSet) { | ||
| sts.Spec.Template.Spec.ShareProcessNamespace = ptr.To(true) | ||
| } |
There was a problem hiding this comment.
Could you add a comment to make it clear what each branch is for? Is the else branch for static appdb?
There was a problem hiding this comment.
yes you are correct -added a comment
There was a problem hiding this comment.
this is not enough?
// we need the upgrade hook and readinessProbe either via init containers or via a side-car and /proc access
// if we don't use init containers we need to use static containers
There was a problem hiding this comment.
Does this mean that for non-static appdb we are now adding 2 init containers?
There was a problem hiding this comment.
we've always had 2 init containers for non static
lucian-tosa
approved these changes
Aug 8, 2025
3 tasks
MaciejKaras
added a commit
that referenced
this pull request
Aug 11, 2025
…ros propagation (#328) # Summary Fixes issue with conflicting `Dockerfile` files on master. Sonar is creating Dockerfiles in the directory where new Dockerfile existed already. They were added here -> #289. Additionally another PR #267 made changes to how the agent images were built and especially to agent Dockerfile ARGs: https://github.com/mongodb/mongodb-kubernetes/blob/89866b79233745e27ade51dc2d9fd0e73c6124e5/docker/mongodb-agent/Dockerfile#L3-L6 This conflicted with #303 where new `atomic_pipeline.py` was still depending on the old Dockerfile structure: https://github.com/mongodb/mongodb-kubernetes/blob/774bbaca930a1752060cfe5e5bf60f24cd6c999c/docker/mongodb-agent/Dockerfile#L25-L26 ## Proof of Work Passing CI (especially agent build task) ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Database:
from:
to:
AppDB:
from:
to:
Summary Changes
This pull request introduces significant changes to the MongoDB Kubernetes operator, focusing on refactoring, architecture updates, and bug fixes. The changes include removing unused dependencies, improving the handling of static and non-static architectures, and enhancing test coverage. Below is a categorized summary of the most important changes:
Refactoring and Code Simplification
buildDatabaseStatefulSetConfigurationFunctionby introducing shared and architecture-specific modifications. [1] [2]InitDatabaseNonStaticImagetoInitDatabaseImageinDatabaseStatefulSetOptionsfor clarity.Static and Non-Static Architecture Handling
buildStaticArchitecturePodTemplateSpecandbuildNonStaticArchitecturePodTemplateSpec) to handle static and non-static architectures, improving modularity and maintainability.AppDbStatefulSetfunction to includeopts.InitAppDBImagewhen defining init containers, ensuring proper handling of both architectures.Enhancements to StatefulSet and Pod Templates
automationUtilitiesPodTemplateFunc) to theappDbPodSpecfor managing utility scripts and hooks, along with corresponding volume mounts. [1] [2]AutomationAgentCommandto include additional startup parameters for better configuration.Proof of Work
Checklist