-
Notifications
You must be signed in to change notification settings - Fork 13
Fix master builds #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix master builds #331
Conversation
MCK 1.3.0 Release NotesBug Fixes
Other Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -71,10 +86,12 @@ def get_version(self) -> str: | |||
return self.git_tag | |||
if self.scenario == BuildScenario.STAGING: | |||
# On master merges, always use "latest" (preserving legacy behavior) | |||
return "latest" | |||
return self.patch_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is not valid anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, good catch
Fixed
Summary
Master patches are broken because they build with
latest
tag only, while the patch still need thepatch_id
tagged images.This PR fixes this issue to get master green again, but remove builds to
latest
.They will be added again in #317, using build_info.
Not pushing to latest only impacts local testing for dev, as we use them to have the most recently built versions from master. It won't break local development, but it means the image used will be slightly outdated.
Proof of Work
I tested it by forcing to return the patch ID and dumping the relevant variables in this patch:
https://spruce.mongodb.com/version/6899d033f94ad4000694cf89/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
But the relevant environment variable (
is_patch
being false, as described in the added documentation) will be set to the right value only when merging to master.