CLOUDP-295785 - staging support for image building #336
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,92 @@ | ||
| { | ||
| "images": { | ||
| "operator": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes", | ||
| "platforms": [ | ||
|
There was a problem hiding this comment. q: Why no arm64 images on staging? Doesn't this conflict with multi-arch tests? cc @nammn There was a problem hiding this comment. I don't know if "linux/arm64" will work for staging. I will leave this to @nammn to add when he will provide his PR with multi-arch support. There was a problem hiding this comment. why shouldn't it work? atomic_pipeline just reads platform and passes it as it is to docker whale? |
||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "init-database": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-init-database", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-init-database", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-init-database", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "init-appdb": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-init-appdb", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-init-appdb", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-init-appdb", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "init-ops-manager": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-init-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-init-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-init-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
|
|
@@ -96,62 +99,140 @@ | |
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-database", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-database", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "meko-tests": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-tests", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-tests", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "mco-tests": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-community-tests", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-community-tests", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "readiness-probe": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-readinessprobe", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-readinessprobe", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "version": "1.0.22", | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-readinessprobe", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "upgrade-hook": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-kubernetes-operator-version-upgrade-post-start-hook", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "latest-tag": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-kubernetes-operator-version-upgrade-post-start-hook", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "version": "1.0.9", | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-kubernetes-operator-version-upgrade-post-start-hook", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "agent": { | ||
| "patch": { | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-agent-ubi", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-agent-ubi", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-agent-ubi", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
| }, | ||
| "ops-manager": { | ||
| "patch": { | ||
| "version": "om-version-from-release.json", | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-enterprise-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "version": "om-version-from-release.json", | ||
| "sign": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/mongodb-enterprise-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| }, | ||
| "release": { | ||
| "version": "om-version-from-release.json", | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/mongodb-enterprise-ops-manager", | ||
| "platforms": [ | ||
| "linux/amd64" | ||
| ] | ||
| } | ||
|
|
@@ -166,6 +247,7 @@ | |
| ] | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "s3-store": "s3://kubectl-mongodb/staging", | ||
| "platforms": [ | ||
| "darwin/amd64", | ||
|
|
@@ -175,6 +257,7 @@ | |
| ] | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "s3-store": "s3://kubectl-mongodb/prod", | ||
| "platforms": [ | ||
| "darwin/amd64", | ||
|
|
@@ -191,9 +274,11 @@ | |
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/helm-charts" | ||
| }, | ||
| "staging": { | ||
| "sign": true, | ||
| "repository": "268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/helm-charts" | ||
| }, | ||
| "release": { | ||
| "sign": true, | ||
| "repository": "quay.io/mongodb/helm-charts" | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. we should later change There was a problem hiding this comment. q: When would this be and how would we trigger the change then? There was a problem hiding this comment. q: Are we going to use staging registry the same way we were using ECR (just for my understanding, but I think it makes sense) There was a problem hiding this comment. As I understand, please correct me if I'm wrong, Because of this we will need to change our There was a problem hiding this comment. Sounds good to me ! Thanks for clarifying :) There was a problem hiding this comment. (I'll let @mircea-cosbuc resolve the thread as he commented as well) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: It seems like this was already configured. What specifically in this PR enables staging support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was configured but unused. Please check -> https://github.com/mongodb/mongodb-kubernetes/pull/336/files#r2273696424