CLOUDP-338090 - remove operator images from update_supported_dockerfiles.py + fix recurrency
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles.py` + fix recurrency
MCK 1.3.0 Release NotesBug Fixes
Other Changes
|
MaciejKaras
added
the
skip-changelog
MaciejKaras
requested review from
mircea-cosbuc and
nammn
and removed request for
fealebenpae
nammn
approved these changes
Aug 14, 2025
viveksinghggits
approved these changes
Sep 1, 2025
Comment on lines
+82
to
+84
| ENTRYPOINT [ "sleep infinity" ] | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| ENTRYPOINT [ "sleep infinity" ] | |
| ENTRYPOINT [ "sleep infinity" ] |
There was a problem hiding this comment.
If you take a look at existing Dockerfiles in that folder, all of them have unnecessary empty lines. This due to how Sonar combines the Dockerfiles. I would like to keep it that way and not reformat them. New Dockerfiles that we will use instead of generated ones by Sonar don't have this issue.
Comment on lines
+82
to
+84
| ENTRYPOINT [ "sleep infinity" ] | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| ENTRYPOINT [ "sleep infinity" ] | |
| ENTRYPOINT [ "sleep infinity" ] |
Comment on lines
+83
to
+84
|
|
||
|
|
Comment on lines
+15
to
+19
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
q: should we remove these unnecessary newlines? I see this in other files as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because we are not pushing
Dockerfilesto S3 for operator related images, I needed to remove them fromSUPPORTED_IMAGES.SUPPORTED_IMAGEScurrently only contains:because they are still build using legacy pipeline.py that sends them to S3. All other
Dockerfilesneed to be added manually during release or stop adding them topublic/dockerfiles/anymore and add them for example as GitHub assets during release.This PR also:
1.2.0release andagent+omfrom recent bumpProof of Work
Passing script before:
and after removing operator related images:
Checklist
skip-changeloglabel if not needed