-
Notifications
You must be signed in to change notification settings - Fork 17
CLOUDP-339609 - migrate repo from mongodb/mongodb-agent-ubi to mongodb/mongodb-agent #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix build scenario Remove create and push manifests Continue improvement to main Simplify main and build_context missed Pass Build Configuration object directly Use legacy and new pipeline Fix Remove --include Rename MCO test image Multi platform builds, with buildx TODOs Implement is_release_step_executed() Fix init appdb image Import sort black formatting Some cleaning and version adjustments Adapt main to new build config Add buildscenario to buildconfig Handle build env Renaming, usage of high level config All images build pass on EVG Lint Explicit image type, support custom build_path Replace old by new pipeline in EVG Add documentation Split in multiple files, cleanup WIP, passing builds on staging temp + multi arch manifests Replace usage of sonar Remove namespace Remove pin_at and build_id Copied pipeline, removed daily builds and --exclude
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. provided some nits.
# Summary This PR fixes an issue with the new agent dockerfiles where the db tools where not placed correctly. The binaries should be present in `/tools`. However, our tests were still passing. For that reason, the agent-script will now fail if the binaries are missing. ## Proof of Work The tests should fail if the binaries are missing. Example: https://spruce.mongodb.com/version/68af05cace35b000077fae05/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC The pipeline should pass. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
VERSION="1.0.1" | ||
docker buildx build --load --progress plain . -f docker/mongodb-kubernetes-database/Dockerfile -t "mongodb-kubernetes-database:${VERSION}" \ | ||
VERSION="1.3.0" | ||
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we committing developer's registry to master?
docker buildx build --load --progress plain . -f docker/mongodb-kubernetes-init-appdb/Dockerfile -t "mongodb-kubernetes-init-appdb:${VERSION}" \ | ||
VERSION="1.3.0" | ||
MONGODB_TOOLS_URL="https://downloads.mongodb.org/tools/db" | ||
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, can we please point it to /dev
atleast?
build_info.json
Outdated
"repositories": ["268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-agent-ubi"], | ||
"platforms": [ | ||
"repositories": ["268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb-agent"], | ||
"platforms": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this indentation change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its annoying, we should add a json and yaml linter otherwise our ides will do whatever they want, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Lucian's dev registry in some files, please make it an env variable or point to a common registry.
Co-authored-by: Vivek Singh <[email protected]>
docker/mongodb-agent/README.md
Outdated
TOOLS_VERSION="100.12.0" | ||
MONGODB_TOOLS_URL="https://downloads.mongodb.org/tools/db" | ||
MONGODB_AGENT_URL="https://mciuploads.s3.amazonaws.com/mms-automation/mongodb-mms-build-agent/builds/automation-agent/prod" | ||
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
LOG_AUTOMATION_CONFIG_DIFF="false" | ||
USE_RACE="false" | ||
docker buildx build --load --progress plain . -f docker/mongodb-kubernetes-operator/Dockerfile -t "mongodb-kubernetes-operator:${VERSION}" \ | ||
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_REPO_URL="268558157000.dkr.ecr.us-east-1.amazonaws.com/lucian.tosa/" |
Summary
This pull request updates all references to the MongoDB agent image to remove the
-ubi
suffix, standardizing onmongodb-agent
instead ofmongodb-agent-ubi
throughout the codebase, configuration files, tests, and documentation. This change ensures consistency across the project and aligns image names with the new naming convention.Image Reference Standardization
Updated all references in Kubernetes manifests, Helm charts, and configuration files to use
quay.io/mongodb/mongodb-agent
instead ofquay.io/mongodb/mongodb-agent-ubi
for agent images and repositories. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Updated
build_info.json
to use the new image repository names for both patch and release builds. [1] [2]Code and Test Updates
Changed all code comments, environment variables, and default values to reference the new agent image name.
Updated all test cases and test configurations to use the new image name, ensuring test coverage matches the new convention. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
Documentation and Output Updates
Updated documentation and generated output files to reflect the new agent image name, ensuring user-facing materials are consistent.
Modified scripts and supporting files to use the new image repository for reporting and automation.
Proof of Work
mongodb-agent
: LinkChecklist
skip-changelog
label if not needed