Skip to content

[flakiness] pytest - use rerunfailures for retries #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[flakiness] pytest - use rerunfailures for retries #391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
52746f8
use rerunfailures
nammn Sep 1, 2025
e76fdb6
use rerunfailures
nammn Sep 1, 2025
5a7cc55
use rerunfailures
nammn Sep 1, 2025
81e5ca9
linter
nammn Sep 1, 2025
8258afb
Merge branch 'master' into add-retries-pytest-dec
nammn Sep 1, 2025
1976f2d
linter
nammn Sep 1, 2025
879e9cc
Merge branch 'add-retries-pytest-dec' of github.com:mongodb/mongodb-k…
nammn Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/mongodb-kubernetes-tests/tests/replicaset/replica_set_pv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def test_replica_set_sts_exists(self):
sts = self.appsv1.read_namespaced_stateful_set("rs001-pv", self.namespace)
assert sts

@pytest.mark.flaky(reruns=3, reruns_delay=2)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statefulset might be ready and then quickly not. Its an intermittent error and we should retry here

https://parsley.mongodb.com/test/mongodb_kubernetes_e2e_mdb_openshift_ubi_cloudqa_e2e_replica_set_pv_patch_6b4107dea46c730d5f2d7a287a94d9850db7123c_68b1e4da263ed10007acf334_25_08_29_17_35_24/0/3d077fd8276a13067e76935d5d189254?bookmarks=0,642&shareLine=0

[2025/08/29 20:27:31.171] FAILURE: assert 2 == 3
[2025/08/29 20:27:31.171]  +  where 2 = {'available_replicas': 2,\n 'collision_count': 0,\n 'conditions': None,\n 'current_replicas': 3,\n 'current_revision': 'rs001-pv-56c4dc5d86',\n 'observed_generation': 1,\n 'ready_replicas': 2,\n 'replicas': 3,\n 'update_revision': 'rs001-pv-56c4dc5d86',\n 'updated_replicas': 3}.ready_replicas
[2025/08/29 20:27:31.17

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and failed again: https://spruce.mongodb.com/task/mongodb_kubernetes_e2e_mdb_openshift_ubi_cloudqa_e2e_replica_set_pv_0da89242153c2177b4e0e86211ef7aba99fd77f0_25_09_01_08_38_49/tests?execution=1&sorts=STATUS%3AASC

def test_sts_creation(self):
sts = self.appsv1.read_namespaced_stateful_set("rs001-pv", self.namespace)

Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@ types-python-dateutil==2.9.0.20250809
pipupgrade==1.12.0
pytest-cov==6.2.1
pytest-socket==0.7.0
pytest-rerunfailures==16.0
Loading