-
Notifications
You must be signed in to change notification settings - Fork 17
fix aws setup for ibm smoke tests #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question
Summary
Python environment and version management:
ensure_required_python
function inrecreate_python_venv.sh
now installs a specific, pinned Python version (3.13.7
by default) for consistency across runs, instead of installing the latest version in a major/minor series. It also removes redundant logic and streamlines the installation process.python3-venv
package on Debian/Ubuntu systems before attempting to set up Python with pyenv, improving compatibility on those platforms.Virtual environment activation and AWS CLI setup:
setup_aws.sh
) has been updated to require and activate the Python venv before installing AWS CLI with pip, ensuring all installations are isolated and reproducible. It also verifies AWS CLI functionality within the venv and reinstalls if necessary.configure_container_auth.sh
) now automatically activates the venv if it exists, which is necessary for AWS CLI usage on IBM architectures.Proof of Work
Checklist
skip-changelog
label if not needed