CLOUDP-322487 - Webhook clusterrole #393
Draft
+77
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces Helm chart unit tests to the CI pipeline and ensures consistent naming for ClusterRole and ClusterRoleBinding resources in the Helm chart. The most important changes are grouped below:
Helm Chart Testing Integration:
Added a
helm-tests
target to theMakefile
to run Helm chart unit tests using thehelm-unittest
plugin. The target installs the plugin if necessary and runs tests in thehelm_chart
directory.Created a
test_helm_unit
function in.evergreen-functions.yml
to execute the new Helm unit tests as part of CI.Added a
unit_tests_helm
task to.evergreen.yml
and included it in theunit_tests_task_group
to ensure Helm unit tests run with other unit tests in the CI pipeline.Helm Chart Improvements and Testing:
Updated
operator-roles-webhook.yaml
to dynamically generate consistent names for ClusterRole and ClusterRoleBinding resources based on the operator name and namespace, preventing naming conflicts across multiple installations.Added a new Helm unit test suite (
webhook_clusterrole_test.yaml
) to verify that ClusterRole and ClusterRoleBinding names are consistent and unique per installation.Proof of Work
Checklist
skip-changelog
label if not needed