Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 10, 2024

Bumps scottbrenner/cfn-lint-action from 2.4.2 to 2.4.5.

Release notes

Sourced from scottbrenner/cfn-lint-action's releases.

Release v2.4.5

What's Changed

Full Changelog: ScottBrenner/cfn-lint-action@v2...v2.4.5

Release v2.4.4

What's Changed

Full Changelog: ScottBrenner/cfn-lint-action@v2...v2.4.4

Release v2.4.3

What's Changed

... (truncated)

Commits
  • e8cae79 chore(deps-dev): Bump eslint from 9.9.1 to 9.10.0 (#438)
  • 05bb4cb chore(deps): Bump actions/upload-artifact from 4.3.6 to 4.4.0 (#437)
  • e8aa0c1 chore(deps): Bump github/codeql-action from 3.26.5 to 3.26.6 (#436)
  • 3712520 chore(deps-dev): Bump lint-staged from 15.2.9 to 15.2.10 (#435)
  • 5a3a37c chore(deps-dev): Bump eslint from 9.9.0 to 9.9.1 (#434)
  • d94e5fb chore(deps-dev): Bump husky from 9.1.4 to 9.1.5 (#433)
  • 0c434fc chore(deps): Bump github/codeql-action from 3.26.0 to 3.26.5 (#432)
  • 57d21bb Update scorecards-analysis.yml (#431)
  • d9f421f FIX: Husky v10 prep (#430)
  • c422b7b FIX: Full installation of cfn-lint package (#429)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 10, 2024 06:29
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 10, 2024
@dependabot dependabot bot force-pushed the dependabot/github_actions/scottbrenner/cfn-lint-action-2.4.5 branch from cee732b to 66dd46d Compare October 1, 2024 08:19
Bumps [scottbrenner/cfn-lint-action](https://github.com/scottbrenner/cfn-lint-action) from 2.4.2 to 2.4.5.
- [Release notes](https://github.com/scottbrenner/cfn-lint-action/releases)
- [Changelog](https://github.com/ScottBrenner/cfn-lint-action/blob/main/CHANGELOG.md)
- [Commits](ScottBrenner/cfn-lint-action@62f1746...e8cae79)

---
updated-dependencies:
- dependency-name: scottbrenner/cfn-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/scottbrenner/cfn-lint-action-2.4.5 branch from 66dd46d to 1d9d2f1 Compare October 8, 2024 09:36
@AgustinBettati
Copy link
Member

Did not figure how the upgrade of this setup action from 2.4.2 is 2.4.5 is impacting how 'cfn-lint' works. In both cases they appear to download the latest version of the CFN lint CLI.
When running locally cfn-lint I cannot reproduce the error faced in the CI.

@lantoli
Copy link
Member

lantoli commented Oct 8, 2024

@AgustinBettati I have been looking at this, I think it was not working fine before because we have to pass the filenames to lint, otherwise it shows the params help. Or maybe it worked in previous versions but I think we were not really linting any file.

I've updated the PR and will merge, I also created a temporary commit to make sure that linter errors are caught, e.g. here.

also printing cfn-lint version so it's easier to reproduce locally

@lantoli lantoli added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit 6160b91 Oct 8, 2024
33 checks passed
@lantoli lantoli deleted the dependabot/github_actions/scottbrenner/cfn-lint-action-2.4.5 branch October 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants