-
Notifications
You must be signed in to change notification settings - Fork 39
chore: Changes only latest version in SDK update #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| go-version-file: 'cfn-resources/go.mod' | ||
| - name: Update files | ||
| run: make tools update-atlas-sdk | ||
| run: make tools update-atlas-sdk generate-mocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate mocks in case mock versions changed
| uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f | ||
| if: steps.verify-changed-files.outputs.files_changed == 'true' | ||
| with: | ||
| token: ${{ secrets.APIX_BOT_PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to have PR checks run
| gomajor get --rewrite "go.mongodb.org/atlas-sdk/${CURRENT_SDK_RELEASE}" "go.mongodb.org/atlas-sdk/${LATEST_SDK_RELEASE}@${LATEST_SDK_TAG}" | ||
| go mod tidy | ||
|
|
||
| LATEST_SDK_STRIPPED_MAYOR_VERSION="${LATEST_SDK_RELEASE%%.*}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LATEST_SDK_RELEASE is already in required format
EspenAlbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Proposed changes
Changes only latest version in SDK update
Jira ticket: CLOUDP-276362
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments