Skip to content

Conversation

@EspenAlbert
Copy link
Contributor

@EspenAlbert EspenAlbert commented Oct 28, 2024

Proposed changes

Removes analytics specs from cluster free example

Link to any related issue(s): based on internal discussion

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

Screenshot CFN
image

Screenshot Atlas
image

@EspenAlbert EspenAlbert marked this pull request as ready for review October 29, 2024 10:16
@EspenAlbert EspenAlbert requested a review from a team as a code owner October 29, 2024 10:16
@EspenAlbert EspenAlbert added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 86a6358 Oct 29, 2024
36 checks passed
@EspenAlbert EspenAlbert deleted the example_cluster_m0 branch October 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants