Skip to content

Conversation

@maastha
Copy link
Collaborator

@maastha maastha commented Mar 18, 2025

Proposed changes

Jira ticket: CLOUDP-273338

This PR:

  • Replaces Realm SDK with the new github.com/mongodb-labs/go-client-mongodb-atlas-app-services SDK.
  • Uses new SDK in Trigger resource.
  • Updates Trigger resource to correct use new attributes.

NOTE TO-DO Follow ups:

  • Release Trigger CFN resource.
  • A follow-up CDK release will be required to support new MaxThroughput attribute.
  • There are still occurences of "realm", these will be replaced with "App Services" in a follow-up PR to keep this PR small.

Link to any related issue(s): mongodb/awscdk-resources-mongodbatlas#350

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

Contract tests local run:

4ba6199551f01399dfd241e', 'ProjectId': '63c80a66f4ed992565d2528e'}} and path ('properties', 'Id')
PASSED                                                                                                              [ 83%]
../../../../../private/var/folders/yg/18z6bwv522j1lg_7sffg1nvw0000gp/T/resource/handler_update.py::contract_update_tag_updatable SKIPPED [ 91%]
../../../../../private/var/folders/yg/18z6bwv522j1lg_7sffg1nvw0000gp/T/resource/handler_update_invalid.py::contract_update_without_create PASSED [100%]

================================= 8 passed, 4 skipped, 12 deselected in 65.14s (0:01:05) ==================================

@maastha maastha marked this pull request as ready for review March 18, 2025 08:26
@maastha maastha requested a review from a team as a code owner March 18, 2025 08:26
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha maastha force-pushed the CLOUDP-273338-trigger-new-attr branch from 60fcac5 to c20024c Compare March 18, 2025 09:32
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +261 to +262
conf.TolerateResumeErrors = dTrigger.TolerateResumeErrors
conf.SkipCatchupEvents = dTrigger.SkipCatchupEvents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties were already defined in our CFN schema but not handled properly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never-mind, cleared my doubt with the CLOUDP ticket

@maastha maastha added this pull request to the merge queue Mar 18, 2025
Merged via the queue into master with commit d3d88a3 Mar 18, 2025
35 checks passed
@maastha maastha deleted the CLOUDP-273338-trigger-new-attr branch March 18, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants