Skip to content

Conversation

@maastha
Copy link
Collaborator

@maastha maastha commented Mar 21, 2025

Proposed changes

Renames "realm" occurrences to App Services. Cleaning up wherever required.

Jira ticket: CLOUDP-273338

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

{
"Name": "cfn-test-trigger-${RANDOM_INT_100K}",
"Type": "DATABASE",
"Profile": "${MONGODB_ATLAS_PROFILE}",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making consistent with other test files

@maastha maastha marked this pull request as ready for review March 24, 2025 10:51
@maastha maastha requested a review from a team as a code owner March 24, 2025 10:51
"Database": "store",
"Collection": "sales",
"ServiceId": "${MONGODB_REALM_SERVICE_ID}",
"ServiceId": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can tests work without ServiceId and FunctionId?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can't but the test script does replace these values with the set env vars (similar to other tests). Removing these from the JSON because I found these placeholders confusing

@maastha maastha added this pull request to the merge queue Mar 25, 2025
Merged via the queue into master with commit a705ceb Mar 25, 2025
36 checks passed
@maastha maastha deleted the trigger-cleanup branch March 25, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants