chore: Upgrades golangci-lint to v2 #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Mar 28, 2025
| hwSpecJSON, err := json.Marshal(hardwareSpec) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, tc.expected, string(hwSpecJSON)) | ||
| assert.JSONEq(t, tc.expected, string(hwSpecJSON)) |
There was a problem hiding this comment.
fixes: encoded-compare: use assert.JSONEq (testifylint)
lantoli
commented
Mar 28, 2025
| hwSpec := config.GetElectableSpecs() | ||
| a.Equal(nodeCount, hwSpec.GetNodeCount()) | ||
| } | ||
| if i == 0 { |
There was a problem hiding this comment.
fixes: QF1003: could use tagged switch on i (staticcheck)
lantoli
commented
Mar 28, 2025
| } | ||
|
|
||
| func integrationToModel(currentModel Model, integration *admin.ThridPartyIntegration) Model { | ||
| enabled := false |
There was a problem hiding this comment.
fixes: QF1007: could merge conditional assignment into variable declaration (staticcheck)
EspenAlbert
approved these changes
Mar 28, 2025
EspenAlbert
reviewed
Mar 28, 2025
| if currentModel.Enabled != nil { | ||
| enabled = true | ||
| } | ||
| enabled := currentModel.Enabled != nil |
There was a problem hiding this comment.
This can never be false?
There was a problem hiding this comment.
can be false if currentModel.Enabled == nil
oarbusi
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrades golangci-lint to v2 using the migration guide, follow example in: mongodb/openapi#616
Jira ticket: CLOUDP-#
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments