MONGOID-5887 Update mongo.rb to add hint in the aggregates #6019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamis
changed the title
jamis
requested changes
Jul 28, 2025
There was a problem hiding this comment.
Thank you, this is a great catch. We should definitely be appending the hint to that request.
Could you add a test or two, to make sure we don't regress at some point in the future? If you aren't sure how to add a test for something like this, you can look at https://github.com/mongodb/mongoid/blob/master/spec/integration/criteria/alias_query_spec.rb#L53-L97 for an example of using event subscribers in specs to inspect the commands as they are sent to the database. I'm happy to answer any questions as well, if that would help.
Thank you!
|
Oh wow. I had seen this behavior but naively assumed hints weren't supported by the aggregation pipeline 🤦♂️ Truly great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoID aggregates dont propagate the hint passed in the criteria, into the pipeline aggregate.
This causes the query to ignore the hint and use an index decided by the planner, which is not ideal for the cases where the user intentionally passed a certain hint.