Skip to content

MONGOID-5890 Correct BSON::Decimal128 handling in normalize_value #6046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MONGOID-5890 Correct BSON::Decimal128 handling in normalize_value #6046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db1eb4c
Correct BSON::Decimal128 handling in normalize_value
johnnyshields Sep 29, 2025
50d06ee
Update comment for BSON::Decimal128 to reflect version change
johnnyshields Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/mongoid/attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,12 @@ def lookup_attribute_presence(name, value)
# comparison purposes. This is necessary because `BSON::Decimal128` does
# not implement `#==` in a way that is compatible with `BigDecimal`.
def normalize_value(value)
value.is_a?(BSON::Decimal128) ? BigDecimal(value.to_s) : value
if value.is_a?(BSON::Decimal128)
# BSON::Decimal128#to_d was introduced in driver version 5.0.0
value.respond_to?(:to_d) ? value.to_d : BigDecimal(value.to_s)
else
value
end
end

# Determine if the attribute will not change, by comparing the current
Expand Down