Skip to content

Conversation

tadjik1
Copy link
Contributor

@tadjik1 tadjik1 commented Oct 6, 2025

Description

Summary of Changes

This PR migrates the integration tests for crud/document_validation. The changes include:

  • Convert file in typescript
  • Refactor callbacks to async/await
  • Direct import from the src folder
Notes for Reviewers

To simplify the review process there is a separate commit for .js -> .ts conversion.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review October 6, 2025 08:25
@tadjik1 tadjik1 requested a review from a team as a code owner October 6, 2025 08:25
@durran durran self-assigned this Oct 6, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 6, 2025
@tadjik1 tadjik1 changed the title test(7191): migrate integration/crud/document_validation tests test(NODE-7191): migrate integration/crud/document_validation tests Oct 7, 2025
@tadjik1 tadjik1 requested a review from durran October 7, 2025 11:45
@durran durran self-requested a review October 7, 2025 14:43
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tadjik1
Copy link
Contributor Author

tadjik1 commented Oct 8, 2025

Yes, thanks @durran, I haven't noticed linting problems at the beginning. It should be fixed now.

@tadjik1 tadjik1 requested a review from durran October 8, 2025 08:27
@durran durran merged commit 25de3df into main Oct 8, 2025
24 of 27 checks passed
@durran durran deleted the NODE-7191 branch October 8, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants