test(7191): migrate integration/crud/document_validation tests
#4714
+210
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
commented
Oct 6, 2025
|
|
||
| // Ensure validation was correctly applied | ||
| const err = await col.insertOne({ b: 1 }).catch(err => err); | ||
| test.ok(err instanceof MongoServerError); |
There was a problem hiding this comment.
We use slightly different approach here to assert an error, in previous version it was test.ok(err != null); and it worked well with callbacks, but with out current promise-based approach this won't work as err will be initialized in both (successful and failed) scenarios.
tadjik1
commented
Oct 6, 2025
| const err = await col | ||
| .updateOne({ b: 1 }, { $set: { b: 1 } }, { upsert: true }) | ||
| .catch(err => err); | ||
| expect(err).to.be.instanceOf(MongoServerError); |
There was a problem hiding this comment.
Same as above, the original test has expect(err).to.exist;.
durran
added
the
Primary Review
durran
requested changes
Oct 6, 2025
|
|
||
| // Ensure validation was correctly applied | ||
| const err = await col.insertOne({ b: 1 }).catch(err => err); | ||
| test.ok(err instanceof MongoServerError); |
There was a problem hiding this comment.
Can we use chai for assertions here?
expect(err).to.be.instanceOf(MongoServerError)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR migrates the integration tests for
crud/document_validation. The changes include:srcfolderNotes for Reviewers
To simplify the review process there is a separate commit for .js -> .ts conversion.
What is the motivation for this change?
This work is part of a larger, ongoing initiative to convert all tests to use
async/await, with the ultimate goal of removing the legacy driver wrapper.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript