Skip to content

fix should correctly receive the APM events for a listIndexes command #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix should correctly receive the APM events for a listIndexes command #4211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 35 additions & 42 deletions test/integration/command-logging-and-monitoring/command_monitoring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
import { expect } from 'chai';

import { ReadPreference } from '../../mongodb';
import { type MongoClient, ReadPreference } from '../../mongodb';
import { filterForCommands, ignoreNsNotFound, setupDatabase } from '../shared';

describe('Command Monitoring', function () {
before(function () {
return setupDatabase(this.configuration);
});

let client: MongoClient;

afterEach(async function () {
await client?.close();
});

it('should correctly receive the APM events for an insert', {
metadata: { requires: { topology: ['single', 'replicaset', 'sharded'] } },

Expand Down Expand Up @@ -98,47 +104,34 @@ describe('Command Monitoring', function () {
}
});

it('should correctly receive the APM events for a listIndexes command', {
metadata: { requires: { topology: ['replicaset'], mongodb: '>=3.0.0' } },

test: function () {
const started = [];
const succeeded = [];
const client = this.configuration.newClient(
{ writeConcern: { w: 1 } },
{ maxPoolSize: 1, monitorCommands: true }
);

const desiredEvents = ['listIndexes', 'find'];
client.on('commandStarted', filterForCommands(desiredEvents, started));
client.on('commandSucceeded', filterForCommands(desiredEvents, succeeded));

const db = client.db(this.configuration.db);

return db
.collection('apm_test_list_collections')
.insertOne({ a: 1 }, this.configuration.writeConcernMax())
.then(r => {
expect(r).property('insertedId').to.exist;

return db
.collection('apm_test_list_collections')
.listIndexes({ readPreference: ReadPreference.PRIMARY })
.toArray();
})
.then(() =>
db
.collection('apm_test_list_collections')
.listIndexes({ readPreference: ReadPreference.SECONDARY })
.toArray()
)
.then(() => {
expect(started).to.have.lengthOf(2);
expect(started[0]).property('address').to.not.equal(started[1].address);

return client.close();
});
}
it('should correctly receive the APM events for a listIndexes command', async function () {
const started = [];
const succeeded = [];
client = this.configuration.newClient(
{ writeConcern: { w: 1 } },
{ maxPoolSize: 1, monitorCommands: true }
);

client.on('commandStarted', filterForCommands('listIndexes', started));
client.on('commandSucceeded', filterForCommands('listIndexes', succeeded));

const db = client.db(this.configuration.db);

await db
.collection('apm_test_list_collections')
.insertOne({ a: 1 }, this.configuration.writeConcernMax());

await db
.collection('apm_test_list_collections')
.listIndexes({ readPreference: ReadPreference.PRIMARY })
.toArray();

await db
.collection('apm_test_list_collections')
.listIndexes({ readPreference: ReadPreference.SECONDARY })
.toArray();
expect(started).to.have.lengthOf(2);
expect(started[0]).property('address').to.not.equal(started[1].address);
});

it('should correctly receive the APM events for a find with getmore and killcursor', {
Expand Down