Skip to content

test(NODE-6317): fix test assertions and naming #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

test(NODE-6317): fix test assertions and naming #4217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,23 +83,20 @@ describe('Monitoring rtt tests', function () {
await promise;
});

it(
'heartbeat duration is not incorrectly reported as zero on ServerHeartbeatSucceededEvents',
{
metadata: {
requires: { topology: '!load-balanced' }
},
test: async function () {
for (const durations of Object.values(heartbeatDurations)) {
const relevantDurations = durations.slice(IGNORE_SIZE);
expect(relevantDurations).to.have.length.gt(0);
const averageDuration =
relevantDurations.reduce((acc, x) => acc + x) / relevantDurations.length;
expect(averageDuration).to.be.gt(DELAY_MS);
}
it('ServerHeartbeatSucceededEvent.duration is greater than or equal to the actual rtt', {
metadata: {
requires: { topology: '!load-balanced' }
},
test: async function () {
for (const durations of Object.values(heartbeatDurations)) {
const relevantDurations = durations.slice(IGNORE_SIZE);
expect(relevantDurations).to.have.length.gt(0);
const averageDuration =
relevantDurations.reduce((acc, x) => acc + x) / relevantDurations.length;
expect(averageDuration).to.be.gte(DELAY_MS);
}
}
);
});

it('ServerDescription.roundTripTime is not incorrectly reported as zero', {
metadata: {
Expand All @@ -114,6 +111,18 @@ describe('Monitoring rtt tests', function () {
}
}
});

it('ServerDescription.roundTripTime is greater than or equal to the actual rtt', {
metadata: {
requires: { topology: '!load-balanced' }
},
test: async function () {
for (const server of Object.keys(heartbeatDurations)) {
const rtt = client.topology.description.servers.get(server).roundTripTime;
expect(rtt).to.be.gte(DELAY_MS);
}
}
});
});
});
}
Expand Down