Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 30, 2024

Description

What is changing?

Not a P3 spec fest ticket, but I noticed all our CMAP tests were out-of-date during other spec-fest work.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 30, 2024 17:36
@dariakp dariakp self-assigned this Oct 30, 2024
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending test check

@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 30, 2024
@dariakp dariakp merged commit 75a4f9a into main Oct 31, 2024
27 of 31 checks passed
@dariakp dariakp deleted the NODE-6110 branch October 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants