Skip to content

test(NODE-5920): do not throw if the server returns unknown saslSupportedMechs #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2024
Merged

test(NODE-5920): do not throw if the server returns unknown saslSupportedMechs #4299

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a28387
asdf
baileympearson Oct 30, 2024
5617814
move test to prose test file
baileympearson Nov 1, 2024
effcbd4
comments
baileympearson Nov 5, 2024
05b3797
add check taht stub is called
baileympearson Nov 6, 2024
7a504fc
Merge branch 'main' into NODE-5920
baileympearson Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions test/integration/mongodb-handshake/mongodb-handshake.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type Sinon from 'sinon';
import * as sinon from 'sinon';

import {
connect,
Connection,
LEGACY_HELLO_COMMAND,
MongoServerError,
Expand Down Expand Up @@ -130,4 +131,38 @@ describe('MongoDB Handshake', () => {
}
});
});

context(
`when the handshake response includes 'saslSupportedMechs' and the array includes an unknown mechanism`,
function () {
beforeEach(() => {
sinon.stub(Connection.prototype, 'command').callsFake(async function (ns, cmd, options) {
// @ts-expect-error: sinon will place wrappedMethod there
const command = Connection.prototype.command.wrappedMethod.bind(this);
if (cmd.hello || cmd[LEGACY_HELLO_COMMAND]) {
return stub();
}
return command(ns, cmd, options);

async function stub() {
const response = await command(ns, cmd, options);
// console.error({ response });
return {
...response,
saslSupportedMechs: [...(response.saslSupportedMechs ?? []), 'random string']
};
}
});
});

afterEach(() => sinon.restore());

it('no error is thrown', { requires: { auth: 'enabled' } }, async function () {
client = this.configuration.newClient();
await client.connect();
await client.db('foo').collection('bar').insertOne({ name: 'john doe' });
await client.close();
});
}
);
});