Skip to content

chore(NODE-6488): specify target=es2021 for ts compilation tests #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

chore(NODE-6488): specify target=es2021 for ts compilation tests #4303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9d50db
fix lint
baileympearson Oct 31, 2024
17c524a
fix ts 4.4
baileympearson Oct 31, 2024
1769cec
add note to readme
baileympearson Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .evergreen/run-typescript.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,12 @@ if [ "$TS_CHECK" == "COMPILE_DRIVER" ]; then
npm run build:ts
elif [ "$TS_CHECK" == "CHECK_TYPES" ]; then
echo "checking driver types"
if [ "$TS_VERSION" == "4.4" ]; then
# check compilation
node $TSC mongodb.d.ts
node $TSC mongodb.d.ts --module commonjs --target es2021
else
node $TSC mongodb.d.ts --module node16 --target es2021
fi
else
"Invalid value $TS_CHECK for TS_CHECK environment variable."
exit 1
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ This is the lowest typescript version guaranteed to work with our driver: older
Since typescript [does not restrict breaking changes to major versions](https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes), we consider this support best effort.
If you run into any unexpected compiler failures against our supported TypeScript versions, please let us know by filing an issue on our [JIRA](https://jira.mongodb.org/browse/NODE).

Additionally, our Typescript types are compatible with the ECMAScript standard for our minimum supported Node version. Currently, our Typescript targets es2021.

## Installation

The recommended way to get started using the Node.js 5.x driver is by using the `npm` (Node Package Manager) to install the dependency in your project.
Expand Down