Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Nov 4, 2024

Description

Update URI spec tests to latest.

What is changing?

Syncs all the URI spec tests.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6467

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review November 5, 2024 18:26
@baileympearson baileympearson self-assigned this Nov 7, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 7, 2024
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one small change. I can't comment on it here, but can we also update the TS type for the options in the URI runner to allow null?

options: Record<string, any>;

It already works at runtime but the type is wrong.

@durran durran requested a review from baileympearson November 8, 2024 15:00
@baileympearson baileympearson merged commit 19ecf07 into main Nov 8, 2024
26 of 29 checks passed
@baileympearson baileympearson deleted the NODE-6467 branch November 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants