Skip to content

fix(NODE-6523): deleteMany in gridfs passes timeoutMS to predicate, not options #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2024
Merged

fix(NODE-6523): deleteMany in gridfs passes timeoutMS to predicate, not options #4319

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83b572b
wip
baileympearson Nov 7, 2024
044e8ea
Apply suggestions from code review
baileympearson Nov 7, 2024
131a251
fix lint
baileympearson Nov 7, 2024
b20b81b
align comments, rework gridfs tests
baileympearson Nov 7, 2024
255f1da
remove measuring of duration
baileympearson Nov 8, 2024
4c1b735
Update test/integration/client-side-operations-timeout/client_side_op…
baileympearson Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/gridfs/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ export class GridFSBucketWriteStream extends Writable {
const remainingTimeMS = this.timeoutContext?.getRemainingTimeMSOrThrow(
`Upload timed out after ${this.timeoutContext?.timeoutMS}ms`
);
await this.chunks.deleteMany({ files_id: this.id, timeoutMS: remainingTimeMS });

await this.chunks.deleteMany({ files_id: this.id }, { timeoutMS: remainingTimeMS });
}
}

Expand Down
Loading