chore(NODE-6502) Use a python venv wherever we use Python in driver CI #4322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
baileympearson
added
the
Primary Review
baileympearson
requested changes
Nov 8, 2024
There was a problem hiding this comment.
It might be working just because the system's Python version is compatible with the drivers-evergreen-tools version, but I do see other places where I think we need to make this change
, for example, should be run using a python venv from drivers-evergreen-tools that has boto3 installed, right?There are other places hard-coded into the config file that also source this script
baileympearson
approved these changes
Nov 11, 2024
5 tasks
blink1073
added a commit
to blink1073/node-mongodb-native
that referenced
this pull request
Nov 12, 2024
mongodb#4322) Co-authored-by: Bailey Pearson <[email protected]> (cherry picked from commit db4eff5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Use scripts from drivers-evergreen-tools instead of using the system python package manager.
Tested against mongodb-labs/drivers-evergreen-tools#545 to ensure there are no regressions in requiring Python 3.8+ syntax.
https://spruce.mongodb.com/version/672e33e060d13d0007e3cdb4/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Some places in Node's CI we rely on the system python/pip, which can lead to compatibility issues when we call drivers-evergreen-tools scripts and broken CI.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript