-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-6620): client.close() interrupts file reads #4355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0af55e9
skeleton
aditi-khare-mongoDB 4798bc2
skeleton updates
aditi-khare-mongoDB 8adca00
refactor for table
aditi-khare-mongoDB 3412bb1
boilerplate execution
aditi-khare-mongoDB 1531bec
fix
aditi-khare-mongoDB 4200f3f
preliminary tests finished
aditi-khare-mongoDB 321ef71
remove misc file
aditi-khare-mongoDB 1503084
temp for screen-share
aditi-khare-mongoDB a128974
lint
aditi-khare-mongoDB 4e55dee
boilerplate fully working
aditi-khare-mongoDB f560088
TLS test case running
aditi-khare-mongoDB ef9cc90
clea up lint
aditi-khare-mongoDB 9ed1528
clean up
aditi-khare-mongoDB 1c8e20f
most of tree reformatting done
aditi-khare-mongoDB 1de9809
reorganized tests and added in most of neal's suggestions
aditi-khare-mongoDB e77405f
TLS test cases and socket test cases
aditi-khare-mongoDB 11aa73c
TLS test cases
aditi-khare-mongoDB c99579a
fix message formatting
aditi-khare-mongoDB 1aeb046
Merge branch 'main' into NODE-6615/integration-client-close
aditi-khare-mongoDB 47c20db
fix message formatting + test cases naming
aditi-khare-mongoDB 133b20d
Delete logs.txt
aditi-khare-mongoDB 8fd53a4
requested changes: remove log calls, change chai to expect, clarify s…
aditi-khare-mongoDB e60a42b
requested changes: additional expectation
aditi-khare-mongoDB d9ed22a
removed resources that we are no longer integration testing - connect…
aditi-khare-mongoDB 83b5685
requested changes: add in exitCode message, skip unimplemented tests,…
aditi-khare-mongoDB 454859e
requested changes: fix exitCode
aditi-khare-mongoDB 5eb92ee
neal's requested changes
aditi-khare-mongoDB 77fadbb
re-add assertion
aditi-khare-mongoDB aefa1cc
Update test/integration/node-specific/resource_tracking_script_builde…
aditi-khare-mongoDB e9a3108
make stderr inherit
aditi-khare-mongoDB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,301 @@ | ||
/* eslint-disable @typescript-eslint/no-empty-function */ | ||
import { type TestConfiguration } from '../../tools/runner/config'; | ||
import { runScriptAndGetProcessInfo } from './resource_tracking_script_builder'; | ||
|
||
describe.skip('MongoClient.close() Integration', () => { | ||
// note: these tests are set-up in accordance of the resource ownership tree | ||
|
||
let config: TestConfiguration; | ||
|
||
beforeEach(function () { | ||
config = this.configuration; | ||
}); | ||
|
||
describe('Node.js resource: TLS File read', () => { | ||
describe('when client is connecting and reads an infinite TLS file', () => { | ||
it('the file read is interrupted by client.close()', async function () { | ||
await runScriptAndGetProcessInfo( | ||
'tls-file-read', | ||
config, | ||
async function run({ MongoClient, uri, expect }) { | ||
const infiniteFile = '/dev/zero'; | ||
const client = new MongoClient(uri, { tls: true, tlsCertificateKeyFile: infiniteFile }); | ||
const connectPromise = client.connect(); | ||
expect(process.getActiveResourcesInfo()).to.include('FSReqPromise'); | ||
await client.close(); | ||
nbbeeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise'); | ||
const err = await connectPromise.catch(e => e); | ||
expect(err).to.exist; | ||
} | ||
); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('MongoClientAuthProviders', () => { | ||
describe('Node.js resource: Token file read', () => { | ||
let tokenFileEnvCache; | ||
|
||
beforeEach(function () { | ||
if (process.env.AUTH === 'auth') { | ||
this.currentTest.skipReason = 'OIDC test environment requires auth disabled'; | ||
return this.skip(); | ||
} | ||
tokenFileEnvCache = process.env.OIDC_TOKEN_FILE; | ||
}); | ||
|
||
afterEach(function () { | ||
process.env.OIDC_TOKEN_FILE = tokenFileEnvCache; | ||
}); | ||
|
||
describe('when MongoClientAuthProviders is instantiated and token file read hangs', () => { | ||
it('the file read is interrupted by client.close()', async () => { | ||
await runScriptAndGetProcessInfo( | ||
'token-file-read', | ||
config, | ||
async function run({ MongoClient, uri, expect }) { | ||
const infiniteFile = '/dev/zero'; | ||
process.env.OIDC_TOKEN_FILE = infiniteFile; | ||
const options = { | ||
authMechanismProperties: { ENVIRONMENT: 'test' }, | ||
authMechanism: 'MONGODB-OIDC' | ||
}; | ||
const client = new MongoClient(uri, options); | ||
client.connect(); | ||
expect(process.getActiveResourcesInfo()).to.include('FSReqPromise'); | ||
await client.close(); | ||
expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise'); | ||
} | ||
); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('Topology', () => { | ||
describe('Node.js resource: Server Selection Timer', () => { | ||
describe('after a Topology is created through client.connect()', () => { | ||
it.skip('server selection timers are cleaned up by client.close()', async () => {}); | ||
}); | ||
}); | ||
|
||
describe('Server', () => { | ||
describe('Monitor', () => { | ||
// connection monitoring is by default turned on - with the exception of load-balanced mode | ||
const metadata: MongoDBMetadataUI = { | ||
requires: { | ||
topology: ['single', 'replicaset', 'sharded'] | ||
} | ||
}; | ||
|
||
describe('MonitorInterval', () => { | ||
describe('Node.js resource: Timer', () => { | ||
describe('after a new monitor is made', () => { | ||
it.skip('monitor interval timer is cleaned up by client.close()', async () => {}); | ||
}); | ||
|
||
describe('after a heartbeat fails', () => { | ||
it.skip('the new monitor interval timer is cleaned up by client.close()', async () => {}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('Connection Monitoring', () => { | ||
describe('Node.js resource: Socket', () => { | ||
it.skip('no sockets remain after client.close()', metadata, async function () {}); | ||
}); | ||
}); | ||
|
||
describe('RTT Pinger', () => { | ||
describe('Node.js resource: Timer', () => { | ||
describe('after entering monitor streaming mode ', () => { | ||
it.skip('the rtt pinger timer is cleaned up by client.close()', async () => { | ||
// helloReply has a topologyVersion defined | ||
}); | ||
}); | ||
}); | ||
|
||
describe('Connection', () => { | ||
describe('Node.js resource: Socket', () => { | ||
describe('when rtt monitoring is turned on', () => { | ||
it.skip('no sockets remain after client.close()', async () => {}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('ConnectionPool', () => { | ||
describe('Node.js resource: minPoolSize timer', () => { | ||
describe('after new connection pool is created', () => { | ||
it.skip('the minPoolSize timer is cleaned up by client.close()', async () => {}); | ||
}); | ||
}); | ||
|
||
describe('Node.js resource: checkOut Timer', () => { | ||
// waitQueueTimeoutMS | ||
describe('after new connection pool is created', () => { | ||
it.skip('the wait queue timer is cleaned up by client.close()', async () => {}); | ||
}); | ||
}); | ||
|
||
describe('Connection', () => { | ||
describe('Node.js resource: Socket', () => { | ||
describe('after a connection is checked out', () => { | ||
it.skip('no sockets remain after client.close()', async () => {}); | ||
}); | ||
|
||
describe('after a minPoolSize has been set on the ConnectionPool', () => { | ||
it.skip('no sockets remain after client.close()', async () => {}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('SrvPoller', () => { | ||
describe('Node.js resource: Timer', () => { | ||
describe('after SRVPoller is created', () => { | ||
it.skip('timers are cleaned up by client.close()', async () => {}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('ClientSession (Implicit)', () => { | ||
describe('Server resource: LSID/ServerSession', () => { | ||
describe('after a clientSession is implicitly created and used', () => { | ||
it.skip('the server-side ServerSession is cleaned up by client.close()', async function () {}); | ||
}); | ||
}); | ||
|
||
describe('Server resource: Transactions', () => { | ||
describe('after a clientSession is implicitly created and used', () => { | ||
it.skip('the server-side transaction is cleaned up by client.close()', async function () {}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('ClientSession (Explicit)', () => { | ||
describe('Server resource: LSID/ServerSession', () => { | ||
describe('after a clientSession is created and used', () => { | ||
it.skip('the server-side ServerSession is cleaned up by client.close()', async function () {}); | ||
}); | ||
}); | ||
|
||
describe('Server resource: Transactions', () => { | ||
describe('after a clientSession is created and used', () => { | ||
it.skip('the server-side transaction is cleaned up by client.close()', async function () {}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('AutoEncrypter', () => { | ||
const metadata: MongoDBMetadataUI = { | ||
requires: { | ||
mongodb: '>=4.2.0', | ||
clientSideEncryption: true | ||
} | ||
}; | ||
|
||
describe('KMS Request', () => { | ||
describe('Node.js resource: TLS file read', () => { | ||
describe('when KMSRequest reads an infinite TLS file', () => { | ||
it('the file read is interrupted by client.close()', async () => { | ||
await runScriptAndGetProcessInfo( | ||
'tls-file-read-auto-encryption', | ||
config, | ||
async function run({ MongoClient, uri, expect, ClientEncryption, BSON }) { | ||
const infiniteFile = '/dev/zero'; | ||
|
||
const kmsProviders = BSON.EJSON.parse(process.env.CSFLE_KMS_PROVIDERS); | ||
const masterKey = { | ||
region: 'us-east-1', | ||
key: 'arn:aws:kms:us-east-1:579766882180:key/89fcc2c4-08b0-4bd9-9f25-e30687b580d0' | ||
}; | ||
const provider = 'aws'; | ||
|
||
const keyVaultClient = new MongoClient(uri); | ||
await keyVaultClient.connect(); | ||
await keyVaultClient.db('keyvault').collection('datakeys'); | ||
|
||
const clientEncryption = new ClientEncryption(keyVaultClient, { | ||
keyVaultNamespace: 'keyvault.datakeys', | ||
kmsProviders | ||
}); | ||
const dataKey = await clientEncryption.createDataKey(provider, { masterKey }); | ||
baileympearson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
function getEncryptExtraOptions() { | ||
if ( | ||
typeof process.env.CRYPT_SHARED_LIB_PATH === 'string' && | ||
process.env.CRYPT_SHARED_LIB_PATH.length > 0 | ||
) { | ||
return { cryptSharedLibPath: process.env.CRYPT_SHARED_LIB_PATH }; | ||
} | ||
return {}; | ||
} | ||
const schemaMap = { | ||
'db.coll': { | ||
bsonType: 'object', | ||
encryptMetadata: { | ||
keyId: [dataKey] | ||
}, | ||
properties: { | ||
a: { | ||
encrypt: { | ||
bsonType: 'int', | ||
algorithm: 'AEAD_AES_256_CBC_HMAC_SHA_512-Random', | ||
keyId: [dataKey] | ||
} | ||
} | ||
} | ||
} | ||
}; | ||
const encryptionOptions = { | ||
autoEncryption: { | ||
keyVaultNamespace: 'keyvault.datakeys', | ||
kmsProviders, | ||
extraOptions: getEncryptExtraOptions(), | ||
schemaMap, | ||
tlsOptions: { aws: { tlsCAFile: infiniteFile } } | ||
} | ||
}; | ||
|
||
const encryptedClient = new MongoClient(uri, encryptionOptions); | ||
await encryptedClient.connect(); | ||
|
||
baileympearson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise'); | ||
|
||
const insertPromise = encryptedClient | ||
.db('db') | ||
.collection('coll') | ||
.insertOne({ a: 1 }); | ||
|
||
expect(process.getActiveResourcesInfo()).to.include('FSReqPromise'); | ||
|
||
await keyVaultClient.close(); | ||
await encryptedClient.close(); | ||
|
||
expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise'); | ||
|
||
const err = await insertPromise.catch(e => e); | ||
expect(err).to.exist; | ||
expect(err.errmsg).to.contain('Error in KMS response'); | ||
} | ||
); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('Node.js resource: Socket', () => { | ||
it.skip('no sockets remain after client.close()', metadata, async () => {}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('Server resource: Cursor', () => { | ||
nbbeeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
describe('after cursors are created', () => { | ||
it.skip('all active server-side cursors are closed by client.close()', async function () {}); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.