Skip to content

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Adds logging perf task
  • Moved perf task construction to gen script
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Understand the perf of logging

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review December 20, 2024 17:03
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Dec 20, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 20, 2024
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments about code placement, LGTM otherwise

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit c392465 into main Dec 20, 2024
31 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6614 branch December 20, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants