ci(NODE-6684): serverless tests use AWS secrets manager #4381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-6684
branch
from
07975a2 to
4b8802e
Compare
baileympearson
commented
Jan 27, 2025
| . ./set-temp-creds.sh | ||
| popd | ||
| MONGODB_URI="${MONGODB_URI}" \ |
There was a problem hiding this comment.
Defining these variables does nothing.
baileympearson
commented
Jan 27, 2025
| source $DRIVERS_TOOLS/.evergreen/init-node-and-npm-env.sh | ||
|
|
||
| if [ -z ${SERVERLESS+omitted} ]; then echo "SERVERLESS is unset" && exit 1; fi | ||
| if [ -z ${SERVERLESS_URI+omitted} ]; then echo "SERVERLESS_URI is unset" && exit 1; fi |
There was a problem hiding this comment.
This variable is never used in our tests because we use the load balanced URIs instead.
baileympearson
commented
Jan 27, 2025
| serverApi?: ServerApi; | ||
| activeResources: number; | ||
| isSrv: boolean; | ||
| serverlessCredentials: { username: string | undefined; password: string | undefined }; |
There was a problem hiding this comment.
This is never set nor used.
baileympearson
commented
Jan 27, 2025
| tests will be skipped. | ||
|
|
||
| Below is a summary of the types of test automation in this repo. | ||
|
|
There was a problem hiding this comment.
I have a markdown linter installed locally. I figured the whitespace changes were fine. I'm also happy to unformat the file or install a markdown plugin for eslint instead.
|
closing in favor of #4385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Serverless tests use AWS secrets manager to fetch credentials to set up the cluster. These tests don't use secretes manager to fetch FLE credentials (https://jira.mongodb.org/browse/NODE-6685).
I also updated the testing readme with instructions on how to use secrets manager and how to setup serverless tests locally.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript