-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(DRIVERS-3096): remove app insights from deployed lambda tests #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we file a drivers ticket so we can create language tickets to go with it? @durran
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adelin suggested removing ApplicationResourceGroup, too, because it is a companion to ApplicationInsightsMonitoring, or is that inaccurate?
@baileympearson @durran Also, it seems like a lot of test failures, do we know what that's all about? |
I removed that now as well. |
No, but they're unrelated. |
Description
Fixes the AWS Lambda CI failures.
What is changing?
Removes app insights in the lambda function as we don't use it.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript