Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 3, 2025

Description

What is changing?

Kerberos tests use secrets manager.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson requested a review from a team as a code owner February 3, 2025 17:48
@durran durran self-assigned this Feb 3, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 3, 2025
@durran
Copy link
Member

durran commented Feb 3, 2025

Also lint failure:

[2025/02/03 19:03:24.624]    37:7   error  'krb5Uri' is never reassigned. Use 'const' instead                                                                                                                          prefer-const
[2025/02/03 19:03:24.624]   221:48  error  Replace `/GSS·failure|UNKNOWN_SERVER|Server·not·found·in·Kerberos·database/` with `⏎··········/GSS·failure|UNKNOWN_SERVER|Server·not·found·in·Kerberos·database/⏎········`  prettier/prettier
[2025/02/03 19:03:24.624] ✖ 2 problems (2 errors, 0 warnings)
[2025/02/03 19:03:24.624]   2 errors and 0 warnings potentially fixable with the `--fix` option.

@baileympearson baileympearson requested a review from durran February 3, 2025 20:54
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on the rc0 of the shared library to get put up for the download failures.

@durran durran merged commit 3a4edd5 into main Feb 4, 2025
22 of 30 checks passed
@durran durran deleted the kerberos-tests branch February 4, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants