Skip to content

fix(NODE-6613): Update error messages when primaries go stale #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 7, 2025
Merged

fix(NODE-6613): Update error messages when primaries go stale #4397

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c6cc7c
Update messages
W-A-James Feb 4, 2025
3205ddd
remove log statements
W-A-James Feb 4, 2025
16efd86
remove console.log
W-A-James Feb 4, 2025
2a714ea
Merge branch 'main' into NODE-6613/fully-implement-spec
W-A-James Feb 4, 2025
669c6d1
code organization
W-A-James Feb 5, 2025
3926158
add unit test
W-A-James Feb 6, 2025
8efe1ef
test cleanup
W-A-James Feb 6, 2025
a85a5fa
update regex
W-A-James Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,12 @@ export class MongoStalePrimaryError extends MongoRuntimeError {
serverDescription: ServerDescription,
maxSetVersion: number | null,
maxElectionId: ObjectId | null,
message?: string,
options?: { cause?: Error }
) {
super(
`primary marked stale due to electionId/setVersion mismatch: server setVersion: ${serverDescription.setVersion}, server electionId: ${serverDescription.electionId}, topology setVersion: ${maxSetVersion}, topology electionId: ${maxElectionId}`,
message ??
`primary marked stale due to electionId/setVersion mismatch: server setVersion: ${serverDescription.setVersion}, server electionId: ${serverDescription.electionId}, topology setVersion: ${maxSetVersion}, topology electionId: ${maxElectionId}`,
options
);
}
Expand Down
7 changes: 6 additions & 1 deletion src/sdam/topology_description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,12 @@ function updateRsFromPrimary(
serverDescriptions.set(
address,
new ServerDescription(server.address, undefined, {
error: new MongoStalePrimaryError(serverDescription, maxSetVersion, maxElectionId)
error: new MongoStalePrimaryError(
serverDescription,
maxSetVersion,
maxElectionId,
'primary marked stale due to discovery of newer primary'
)
})
);

Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
"servers": {
"a:27017": {
"type": "Unknown",
"setName": null
"setName": null,
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ phases: [
"a:27017": {

type: "Unknown",
setName:
setName:,
error: "primary marked stale due to discovery of newer primary"
},

"b:27017": {
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary_new_electionid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary_new_electionid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ phases: [
type: "Unknown",
setName: ,
electionId: ,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary_new_setversion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/new_primary_new_setversion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/primary_disconnect_electionid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down Expand Up @@ -125,6 +125,7 @@
"a:27017": {
"type": "Unknown",
"setName": null,
"error": "primary marked stale due to electionId/setVersion mismatch",
"electionId": null
},
"b:27017": {
Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/primary_disconnect_electionid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down Expand Up @@ -100,6 +100,7 @@ phases: [
"a:27017": {
type: "Unknown",
setName: ,
error: "primary marked stale due to electionId/setVersion mismatch",
electionId:
},
"b:27017": {
Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/primary_disconnect_setversion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down Expand Up @@ -125,6 +125,7 @@
"a:27017": {
"type": "Unknown",
"setName": null,
"error": "primary marked stale due to electionId/setVersion mismatch",
"electionId": null
},
"b:27017": {
Expand Down
3 changes: 2 additions & 1 deletion test/spec/server-discovery-and-monitoring/rs/primary_disconnect_setversion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down Expand Up @@ -100,6 +100,7 @@ phases: [
"a:27017": {
type: "Unknown",
setName: ,
error: "primary marked stale due to electionId/setVersion mismatch",
electionId:
},
"b:27017": {
Expand Down
2 changes: 1 addition & 1 deletion ...pec/server-discovery-and-monitoring/rs/setversion_greaterthan_max_without_electionid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion ...spec/server-discovery-and-monitoring/rs/setversion_greaterthan_max_without_electionid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/setversion_without_electionid-pre-6.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/setversion_without_electionid-pre-6.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/use_setversion_without_electionid-pre-6.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"type": "Unknown",
"setName": null,
"electionId": null,
"error": "primary marked stale due to electionId/setVersion mismatch"
"error": "primary marked stale due to discovery of newer primary"
},
"b:27017": {
"type": "RSPrimary",
Expand Down
2 changes: 1 addition & 1 deletion test/spec/server-discovery-and-monitoring/rs/use_setversion_without_electionid-pre-6.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ phases: [
type: "Unknown",
setName: ,
electionId:,
error: "primary marked stale due to electionId/setVersion mismatch"
error: "primary marked stale due to discovery of newer primary"
},
"b:27017": {
type: "RSPrimary",
Expand Down