Skip to content

test(NODE-6723): isolate and warmup benchmarks #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 6, 2025
Merged

test(NODE-6723): isolate and warmup benchmarks #4398

merged 12 commits into from
Feb 6, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 4, 2025 •
edited
Loading

Description

What is changing?

  • move benchmark code to their own files
  • launch each benchmark in its own process
  • warm up benchmark code
  • correct runtime/runcount conditions and print them
Is there new documentation needed for these changes?

What is the motivation for this change?

We want more stable results from our benchmarks, warmup and isolation should help.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6705-isolate-benches branch from 577cd4a to ff80bb4 Compare February 4, 2025 22:12
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Feb 4, 2025

running here

@nbbeeken nbbeeken marked this pull request as ready for review February 4, 2025 22:48
@nbbeeken nbbeeken requested a review from a team as a code owner February 4, 2025 22:48
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 4, 2025
@W-A-James W-A-James requested review from W-A-James and removed request for a team February 4, 2025 22:59
W-A-James
W-A-James suggested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple cleanup comments and a question. Otherwise lgtm

@nbbeeken nbbeeken changed the title test(NODE-6705): isolate and warmup benchmarks test(NODE-6723): isolate and warmup benchmarks Feb 5, 2025
@nbbeeken nbbeeken force-pushed the NODE-6705-isolate-benches branch from 73b67cd to 908647b Compare February 5, 2025 15:22
@W-A-James W-A-James self-requested a review February 5, 2025 16:22
W-A-James
W-A-James previously approved these changes Feb 5, 2025
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 5, 2025
W-A-James
W-A-James reviewed Feb 5, 2025
View reviewed changes
W-A-James
W-A-James reviewed Feb 5, 2025
View reviewed changes
W-A-James
W-A-James suggested changes Feb 5, 2025
View reviewed changes
W-A-James
W-A-James previously approved these changes Feb 5, 2025
View reviewed changes
baileympearson
baileympearson requested changes Feb 5, 2025
View reviewed changes
baileympearson
baileympearson approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes, LGTM.

@nbbeeken nbbeeken merged commit a1c83de into main Feb 6, 2025
27 of 30 checks passed
@nbbeeken nbbeeken deleted the NODE-6705-isolate-benches branch February 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baileympearson baileympearson baileympearson approved these changes

+1 more reviewer

@W-A-James W-A-James W-A-James left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@W-A-James W-A-James

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nbbeeken @baileympearson @W-A-James