-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(NODE-6720): migrate multibench tests #4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b7cb2c
to
d24a4d4
Compare
nbbeeken
commented
Feb 6, 2025
...enchmarks/driver_bench/src/suites/multi_bench/aggregate_a_million_documents_and_to_array.mts
Show resolved
Hide resolved
...enchmarks/driver_bench/src/suites/multi_bench/aggregate_a_million_documents_and_to_array.mts
Show resolved
Hide resolved
test/benchmarks/driver_bench/src/suites/multi_bench/grid_fs_download.mts
Show resolved
Hide resolved
test/benchmarks/driver_bench/src/suites/multi_bench/large_doc_bulk_insert.mts
Show resolved
Hide resolved
415aa0f
to
827266c
Compare
827266c
to
ff73b41
Compare
baileympearson
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor changes
test/benchmarks/driver_bench/src/suites/multi_bench/grid_fs_download.mts
Show resolved
Hide resolved
baileympearson
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Move to the new isolated and warm up bench system
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript