Skip to content

ci(NODE-6737): LDAP tests use secrets manager #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

ci(NODE-6737): LDAP tests use secrets manager #4407

merged 1 commit into from
Feb 10, 2025

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson requested a review from a team as a code owner February 7, 2025 19:22
@durran durran self-assigned this Feb 10, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 10, 2025
@durran durran merged commit 74281a5 into main Feb 10, 2025
24 of 30 checks passed
@durran durran deleted the NODE-6737-secrets-manager-ldap branch February 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @durran