Skip to content

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 11, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Let the lock file update to pull in the prebuild with the N-API parse fix

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner February 11, 2025 16:43
@baileympearson baileympearson self-assigned this Feb 11, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 11, 2025
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Feb 11, 2025

baileympearson
baileympearson previously approved these changes Feb 11, 2025
@nbbeeken nbbeeken changed the title ci: fix zstd build ci: pull in fixed prebuild version and add kerberos to dev dependencies Feb 11, 2025
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ECS tests are all failing with a different error (it's not the AWS_PROFILE issue): https://spruce.mongodb.com/version/67abdbd064e502000731fb23/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@nbbeeken
Copy link
Contributor Author

@baileympearson baileympearson merged commit b8bf5c8 into main Feb 12, 2025
26 of 29 checks passed
@baileympearson baileympearson deleted the fix-zstd-build branch February 12, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants