Skip to content

ci(NODE-6791): make deployed KMS tests run again #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2025
Merged

ci(NODE-6791): make deployed KMS tests run again #4451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c89ebb
fix skipping of KMS tests
baileympearson Mar 5, 2025
5f9f206
Merge branch 'main' into KMS-tests
baileympearson Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions .../integration/client-side-encryption/client_side_encryption.prose.17.on_demand_gcp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ import { env } from 'process';
import { ClientEncryption } from '../../../src/client-side-encryption/client_encryption';
import { Binary } from '../../mongodb';

const metadata: MongoDBMetadataUI = {
requires: {
clientSideEncryption: true
}
} as const;

const dataKeyOptions = {
masterKey: {
projectId: 'devprod-drivers',
Expand Down Expand Up @@ -45,25 +39,39 @@ describe('17. On-demand GCP Credentials', () => {
await keyVaultClient?.close();
});

it('Case 1: Failure', metadata, async function () {
if (env.EXPECTED_GCPKMS_OUTCOME !== 'failure') {
this.skipReason = 'This test is supposed to run in the environment where failure is expected';
this.skip();
it(
'Case 1: Failure',
{
requires: {
predicate: () =>
env.EXPECTED_GCPKMS_OUTCOME !== 'failure'
? 'This test is supposed to run in the environment where failure is expected'
: true
}
},
async function () {
const error = await clientEncryption
.createDataKey('gcp', dataKeyOptions)
.catch(error => error);
// GaxiosError: Unsuccessful response status code. Request failed with status code 404
expect(error).to.be.instanceOf(Error);
expect(error).property('code', '404');
}
);

const error = await clientEncryption.createDataKey('gcp', dataKeyOptions).catch(error => error);
// GaxiosError: Unsuccessful response status code. Request failed with status code 404
expect(error).to.be.instanceOf(Error);
expect(error).property('code', '404');
});

it('Case 2: Success', metadata, async function () {
if (env.EXPECTED_GCPKMS_OUTCOME !== 'success') {
this.skipReason = 'This test is supposed to run in the environment where success is expected';
this.skip();
it(
'Case 2: Success',
{
requires: {
predicate: () =>
env.EXPECTED_GCPKMS_OUTCOME !== 'success'
? 'This test is supposed to run in the environment where success is expected'
: true
}
},
async function () {
const dk = await clientEncryption.createDataKey('gcp', dataKeyOptions);
expect(dk).to.be.instanceOf(Binary);
}

const dk = await clientEncryption.createDataKey('gcp', dataKeyOptions);
expect(dk).to.be.instanceOf(Binary);
});
);
});
54 changes: 30 additions & 24 deletions ...ntegration/client-side-encryption/client_side_encryption.prose.19.on_demand_azure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ import { ClientEncryption } from '../../../src/client-side-encryption/client_enc
import { MongoCryptAzureKMSRequestError } from '../../../src/client-side-encryption/errors';
import { Binary } from '../../mongodb';

const metadata: MongoDBMetadataUI = {
requires: {
clientSideEncryption: true
}
} as const;

const dataKeyOptions = {
masterKey: {
keyVaultEndpoint: 'https://drivers-2411-keyvault.vault.azure.net/',
Expand Down Expand Up @@ -48,25 +42,37 @@ describe('19. On-demand Azure Credentials', () => {
await keyVaultClient?.close();
});

it('Case 1: Failure', metadata, async function () {
if (env.EXPECTED_AZUREKMS_OUTCOME !== 'failure') {
this.skipReason = 'This test is supposed to run in the environment where failure is expected';
this.skip();
it(
'Case 1: Failure',
{
requires: {
predicate: () =>
env.EXPECTED_AZUREKMS_OUTCOME !== 'failure'
? 'This test is supposed to run in the environment where failure is expected'
: true
}
},
async function () {
const error = await clientEncryption
.createDataKey('azure', dataKeyOptions)
.catch(error => error);
expect(error).to.be.instanceOf(MongoCryptAzureKMSRequestError);
}
);

const error = await clientEncryption
.createDataKey('azure', dataKeyOptions)
.catch(error => error);
expect(error).to.be.instanceOf(MongoCryptAzureKMSRequestError);
});

it('Case 2: Success', metadata, async function () {
if (env.EXPECTED_AZUREKMS_OUTCOME !== 'success') {
this.skipReason = 'This test is supposed to run in the environment where success is expected';
this.skip();
it(
'Case 2: Success',
{
requires: {
predicate: () =>
env.EXPECTED_AZUREKMS_OUTCOME !== 'success'
? 'This test is supposed to run in the environment where success is expected'
: true
}
},
async function () {
const dk = await clientEncryption.createDataKey('azure', dataKeyOptions);
expect(dk).to.be.instanceOf(Binary);
}

const dk = await clientEncryption.createDataKey('azure', dataKeyOptions);
expect(dk).to.be.instanceOf(Binary);
});
);
});