Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/benchmarks/driver_bench/src/driver.mts
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export type Metric = {
name: 'megabytes_per_second' | 'normalized_throughput';
value: number;
metadata: {
tags?: string[];
improvement_direction: 'up' | 'down';
};
};
Expand All @@ -143,7 +144,6 @@ export type MetricInfo = {
info: {
test_name: string;
args: Record<string, number>;
tags?: string[];
};
metrics: Metric[];
};
Expand All @@ -159,12 +159,15 @@ export function metrics(test_name: string, result: number, tags?: string[]): Met
key,
typeof value === 'number' ? value : value ? 1 : 0
])
),
tags
)
},
// FIXME(NODE-6781): For now all of our metrics are of throughput so their improvement_direction is up,
metrics: [
{ name: 'megabytes_per_second', value: result, metadata: { improvement_direction: 'up' } }
{
name: 'megabytes_per_second',
value: result,
metadata: { tags, improvement_direction: 'up' }
}
]
} as const;
}
Expand Down