-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(NODE-6844): modernize defer and remove incorrect usages #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,52 @@ | ||
| 'use strict'; | ||
|
|
||
| const kDeferred = Symbol('deferred'); | ||
| const mocha = require('mocha'); | ||
|
|
||
| (mocha => { | ||
| const Context = mocha.Context; | ||
| function makeExecuteDeferred(test) { | ||
| return () => { | ||
| const deferredActions = test[kDeferred]; | ||
|
|
||
| // process actions LIFO | ||
| const promises = Array.from(deferredActions).reverse(); | ||
| const result = promises.reduce((p, action) => { | ||
| if (action.length > 0) { | ||
| // assume these are async methods with provided `done` | ||
| const actionPromise = new Promise((resolve, reject) => { | ||
| function done(err) { | ||
| if (err) return reject(err); | ||
| resolve(); | ||
| } | ||
|
|
||
| action(done); | ||
| }); | ||
|
|
||
| return p.then(actionPromise); | ||
| } | ||
|
|
||
| return p.then(action); | ||
| }, Promise.resolve()); | ||
|
|
||
| return result.then( | ||
| () => test[kDeferred].clear(), | ||
| err => { | ||
| test[kDeferred].clear(); | ||
| return Promise.reject(err); | ||
| } | ||
| ); | ||
| }; | ||
| } | ||
| const { Context } = mocha; | ||
|
|
||
| Context.prototype.defer = function (fn) { | ||
| const test = this.test; | ||
| if (test[kDeferred] == null) { | ||
| test[kDeferred] = new Set(); | ||
| function makeExecuteDeferred(test) { | ||
| return async function () { | ||
| /** @type {Array<() => Promise<void>>} */ | ||
| const deferredActions = test[kDeferred]; | ||
|
|
||
| const parentSuite = test.parent; | ||
| const afterEachHooks = parentSuite._afterEach; | ||
| if (afterEachHooks[0] == null || afterEachHooks[0].title !== kDeferred) { | ||
| const deferredHook = parentSuite._createHook('"deferred" hook', makeExecuteDeferred(test)); | ||
| // process actions LIFO | ||
| const actions = Array.from(deferredActions).reverse(); | ||
|
|
||
| afterEachHooks.unshift(deferredHook); | ||
| try { | ||
| for (const fn of actions) { | ||
| await fn(); | ||
| } | ||
| } finally { | ||
| test[kDeferred].length = 0; | ||
| } | ||
|
|
||
| test[kDeferred].add(fn); | ||
| return this; | ||
| }; | ||
| })(require('mocha')); | ||
| } | ||
|
|
||
| Context.prototype.defer = function defer(fn) { | ||
| const test = this.test; | ||
|
|
||
| if (typeof fn !== 'function') { | ||
| throw new Error('defer is meant to take a function that returns a promise'); | ||
| } | ||
|
|
||
| if (test[kDeferred] == null) { | ||
| test[kDeferred] = []; | ||
|
|
||
| const parentSuite = test.parent; | ||
| const afterEachHooks = parentSuite._afterEach; | ||
| if (afterEachHooks[0] == null || afterEachHooks[0].title !== kDeferred) { | ||
| const deferredHook = parentSuite._createHook('"deferred" hook', makeExecuteDeferred(test)); | ||
|
|
||
| // defer runs after test but before afterEach(s) | ||
| afterEachHooks.unshift(deferredHook); | ||
| } | ||
| } | ||
|
|
||
| if (test[kDeferred].includes(fn)) { | ||
| throw new Error('registered the same deferred action more than once'); | ||
| } | ||
|
|
||
| test[kDeferred].push(fn); | ||
| return this; | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.