Skip to content

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • remove callback based test
Is there new documentation needed for these changes?

What is the motivation for this change?

The test flaked but it isn't the correct coverage for our API. The promises test covers the same concept

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner March 12, 2025 15:38
@dariakp dariakp self-assigned this Mar 12, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 12, 2025
@dariakp dariakp merged commit d9c7afc into main Mar 12, 2025
11 of 12 checks passed
@dariakp dariakp deleted the NODE-6846-cs-callback-test branch March 12, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants