Skip to content

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Flaky test

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner March 12, 2025 18:25
… #markCommand when csot is enabled and markCommand() takes longer than the remaining timeoutMS the command should fail due to a timeout error test
@nbbeeken nbbeeken force-pushed the NODE-6850-markCommand-flake branch from 870e8d1 to bea7fd8 Compare March 12, 2025 18:48
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 12, 2025
@baileympearson baileympearson self-assigned this Mar 12, 2025
@baileympearson baileympearson merged commit 6895b25 into main Mar 13, 2025
27 of 30 checks passed
@baileympearson baileympearson deleted the NODE-6850-markCommand-flake branch March 13, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants